Extract evaluate splits from CPU hist. #7079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
yes. It's not used now, gradients are set to zero instead. |
|
@ShvetsKS Thanks for the reply. Could you help review this PR? I will remove the |
hcho3
approved these changes
Jul 7, 2021
ShvetsKS
reviewed
Jul 7, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than modularizing the split evaluation function, this PR also removes some more functions including
InitNewNodesandBuildNodeStatsamong some other unused variables. Also, scattered code like setting leaf weights is grouped into the split evaluator andNodeEntryis simplified and made private. Another subtle difference with the original implementation is that the modified code doesn't calltree[nidx].Parent()to traversal upward.perf
I think it's faster after the PR. URL is only run for 100 rounds, others are 500 rounds.